Closed filipegoncalves closed 9 years ago
Looks good, thanks!
Using unstable features without #![feature(...)]
is now also an error. (See Travis-CI logs.) Could you fix that as well?
Thanks for the feedback. I updated the PR to fix the unstable features error.
Adding #![feature(core)]
to the crate's attributes does seem to solve the additional errors, just like the compiler suggests, but although all the errors go away, it spits a somewhat annoying warning about "unused or unknown feature". After a brief discussion on IRC, it seems like a bug in rust internals.
I decided to leave it like that for now, since there's no apparent fix to make the warning disappear.
It looks like some of the *-index
crates also need #![feature(core)]
(or perhaps #![cfg_attr(test, feature(core))]
) as well. You can run make test
to run tests in every crate.
… and by the time I typed this, I see you’ve already pushed a fix :)
Yep, I saw it :) It should build now.
UPDATE: turns out the warning is not a bug in Rust. It was my fault - indeed, feature(core)
in some cases was needed for tests only, wrapping it in cfg_attr
fixed it.
Thank you!
As of the latest nightly, the rules in https://github.com/rust-lang/rfcs/blob/master/text/0940-hyphens-considered-harmful.md are now fully implemented and in use. This patch fixes the errors on
cargo build
that arise when attempting to build projects that depend on this library: