search

lifthrasiir / rust-encoding

Character encoding support for Rust
MIT License
284 stars 59 forks source link

Change hyphen to _ #87

Closed marvelm closed 9 years ago

marvelm commented 9 years ago

I'm getting errors when building crates which depend on "encoding-index-*" crates because of the hyphen.

cargo build Unable to get packages from source

Caused by: failed to parse manifest at .../.cargo/registry/src/github.com-1ecc6299db9ec823/encoding-index-tradchinese-1.20141219.2/Cargo.toml

Caused by: library target names cannot contain hyphens: encoding-index-tradchinese

SimonSapin commented 9 years ago

Aren’t you just using an older version? The latest on https://crates.io/crates/encoding-index-tradchinese is 1.20141219.5, not 1.20141219.2. Try cargo update?

SimonSapin commented 9 years ago

To clarify: I don’t think this change is necessary or that it actually fixes your issue.

marvelm commented 9 years ago

Thank you!