search

lifting-bits / cxx-common

Common dependency management for various Trail of Bits C++ codebases
Apache License 2.0
31 stars 11 forks source link

Build for 22.04 #970

Closed Ninja3047 closed 1 year ago

Ninja3047 commented 2 years ago

Blocked on remill issues building with glibc 2.34 due to SIGSTKSZ no longer being constant https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=865157146427eff9819386eb5237900b0a6260be;hb=refs/heads/release/2.34/master#l149

maxammann commented 1 year ago

This is strange, for me remill builds for 22.04 worked. I wonder what the difference is 🤔

maxammann commented 1 year ago

When _DYNAMIC_STACK_SIZE_SOURCE or _GNU_SOURCE are defined, MINSIGSTKSZ and SIGSTKSZ are no longer constant on Linux.

Maybe both of those variables are not defined in my environment? 🤔

ekilmer commented 1 year ago

This is strange, for me remill builds for 22.04 worked. I wonder what the difference is 🤔

@maxammann Remill tests build and pass for you on 22.04? They don't work in CI (as you can see) and on my Fedora 36 machine due to the glibc change. Very weird.

maxammann commented 1 year ago

@maxammann Remill tests build and pass for you on 22.04? They don't work in CI (as you can see) and on my Fedora 36 machine due to the glibc change. Very weird.

I'm not sure what you mean with "tests build". So I only got the normal release builds of remill working: 

cmake --build
ekilmer commented 1 year ago

@maxammann Remill tests build and pass for you on 22.04? They don't work in CI (as you can see) and on my Fedora 36 machine due to the glibc change. Very weird.

I'm not sure what you mean with "tests build". So I only got the normal release builds of remill working:

cmake --build

There's another command (the one that's failing in this PR) to build tests:

cmake --build --target test_dependencies

And then you should be able to run ctest in the build directory to run the tests.