Rewrite build-dependencies.sh in python/cmake

lifting-bits / cxx-common

Common dependency management for various Trail of Bits C++ codebases

Apache License 2.0

31 stars 11 forks source link

Open mrexodia opened 1 year ago

mrexodia commented 1 year ago

It looks like build-dependencies.sh currently only works on Linux (on macos 12 I get errors related to https://github.com/lifting-bits/cxx-common/blob/master/build_dependencies.sh#L95).

Would be nice if this script was rewritten in python or cmake so Windows can also be supported.

ekilmer commented 1 year ago

Are the bash errors related to an old version of bash that comes pre-installed on macOS? (Check this issue https://github.com/lifting-bits/cxx-common/issues/953)

Would be nice if this script was rewritten in python or cmake so Windows can also be supported.

Rewriting in Python3 (ideally version 3.7 minimum) would be nice. I'll consider it.

mrexodia commented 1 year ago

Yeah I guess that’s the problem. If you want I can send a PR with a fix, I just replaced-z with a different pattern.

perhaps changing from bash to “sh” would be better though (given zsh supports the script)

ekilmer commented 1 year ago

A PR would be great! Thank you!

Edit: PR was made as #985