search

lifting-bits / remill

Library for lifting machine code to LLVM bitcode
Apache License 2.0
1.27k stars 143 forks source link

Use _WIN32 instead of WIN32 to fix Windows builds #498

Closed mrexodia closed 3 years ago

mrexodia commented 3 years ago

See https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160

With this fix I can compile remill with clang-cl and with -DVCPKG_ROOT= https://github.com/trailofbits/cxx-common/releases/download/v0.1.2/vcpkg_windows-vs2019_llvm-11_amd64.7z

mrexodia commented 3 years ago

I didn’t see that before, interesting... In my case I was using clang-cl so maybe that’s why 🤷🏻‍♂️ Either way, thanks for the quick merge!

On Mon, 22 Mar 2021 at 14:59, Eric Kilmer @.***> wrote:

Merged #498 https://github.com/lifting-bits/remill/pull/498 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lifting-bits/remill/pull/498#event-4490302218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASYFGLMGM4TQEWBDM6ILHTTE5EK7ANCNFSM4ZQ5OE2Q .