search

lifting-bits / remill

Library for lifting machine code to LLVM bitcode
Apache License 2.0
1.22k stars 142 forks source link

RPM build failing due to invalid release tag #616

Closed tetsuo-cpp closed 1 year ago

tetsuo-cpp commented 1 year ago

This has been happening since the irene2-final tag was pushed:

+ cpack -D REMILL_DATA_PATH=/__w/remill/remill/remill-build/install -R rene2-final.854c73e --config /__w/remill/remill/packaging/main.cmake
-- Installing: /__w/remill/remill/remill-build/install/usr/local/lib/cmake/remill/remillTargets.cmake
-- Installing: /__w/remill/remill/remill-build/install/usr/local/lib/cmake/remill/remillTargets-relwithdebinfo.cmake
CPack: Create package using TGZ
CPack: Install projects
CPack: - Install directory: /__w/remill/remill/remill-build/install
CPack: Create package
CPack: - package: /__w/remill/remill/remill-build/remill-rene2-final.854c73e-x86_64.tar.gz generated.
CPack: Create package using DEB
CPack: Install projects
CPack: - Install directory: /__w/remill/remill/remill-build/install
CPack: Create package
CMake Warning (dev) at /usr/local/share/cmake-3.22/Modules/Internal/CPack/CPackDeb.cmake:406 (message):
  CPackDeb: Debian package versioning ([<epoch>:]<version>[-<release>])
  should confirm to "^([0-9]+:)?[0-9][A-Za-z0-9.+~-]*$" regex in order to
  satisfy Debian packaging rules.
Call Stack (most recent call first):
  /usr/local/share/cmake-3.22/Modules/Internal/CPack/CPackDeb.cmake:793 (cpack_deb_prepare_package_vars)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- CPACK_DEBIAN_PACKAGE_DEPENDS not set, the package will have no dependencies.
CPack: - package: /__w/remill/remill/remill-build/remill-rene2-final.854c73e-x86_64.deb generated.
CPack: Create package using RPM
CPack: Install projects
CPack: - Install directory: /__w/remill/remill/remill-build/install
CPack: Create package
CPackRPM: Will use GENERATED spec file: /__w/remill/remill/remill-build/_CPack_Packages/RPM/SPECS/remill.spec
CPackRPM:Debug: You may consult rpmbuild logs in: 
CPackRPM:Debug:    - /__w/remill/remill/remill-build/_CPack_Packages/RPM/rpmbuildremill.err
CPackRPM:Debug: *** error: line 10: Illegal char '-' (0x2d) in: Release:        rene2-final.854c73e
 ***
CPackRPM:Debug:    - /__w/remill/remill/remill-build/_CPack_Packages/RPM/rpmbuildremill.out
CPackRPM:Debug: *** Building target platforms: x86_64
Building for target x86_64
 ***
CMake Error at /usr/local/share/cmake-3.22/Modules/Internal/CPack/CPackRPM.cmake:1897 (message):
  RPM package was not generated!
  /__w/remill/remill/remill-build/_CPack_Packages/RPM
Call Stack (most recent call first):
  /usr/local/share/cmake-3.22/Modules/Internal/CPack/CPackRPM.cmake:1968 (cpack_rpm_generate_package)

CPack Error: Error while execution CPackRPM.cmake
CPack Error: Problem compressing the directory
CPack Error: Error when generating package: remill
[x] Build aborted.
Error: Process completed with exit code 1.

Could we maybe make this a branch instead of a tag? Alternatively, we could just ignore this until we push a tag for the next release.

tetsuo-cpp commented 1 year ago

Solved with https://github.com/lifting-bits/remill/releases/tag/v5.0.7.