search

lifting-bits / remill

Library for lifting machine code to LLVM bitcode
Apache License 2.0
1.27k stars 145 forks source link

PPC tests #644

Closed Ninja3047 closed 1 year ago

Ninja3047 commented 1 year ago

Work in progress tests for the work in progress PPC architecture support Tests are expected to fail at the moment

tetsuo-cpp commented 1 year ago

@Ninja3047 If you merge in my latest fixes, the instruction that was complaining about a non-existent TEA register should work.

tetsuo-cpp commented 1 year ago

3929ad4 looks good to me. I'm going to cherrypick that to alex/ppc.

Thanks @Ninja3047.

Ninja3047 commented 1 year ago

These are looking good! I'll take another pass tomorrow and merge it in.

Tests are expected to fail at the moment

Is this still the case?

tests should be passing besides the few that are disabled

tetsuo-cpp commented 1 year ago

@Ninja3047 Is this ready to go? Or are you still planning to push more to it.

Ninja3047 commented 1 year ago

Should be good to go

tetsuo-cpp commented 1 year ago

Awesome work. I'm going to go ahead and merge this since I'm getting the main PPC branch ready for review.

@lkorenc I'm intending to add you as a reviewer to https://github.com/lifting-bits/remill/pull/645 once it's ready. So if you had further feedback about the tests, we can cover that there too.