search

lifting-bits / remill

Library for lifting machine code to LLVM bitcode
Apache License 2.0
1.22k stars 143 forks source link

Test on Ubuntu 22.04 #660

Closed ekilmer closed 1 year ago

ekilmer commented 1 year ago

Some tests are failing on Ubuntu 22.04, and I'm not sure how to fix them.

closes #647

tetsuo-cpp commented 1 year ago

@ekilmer I can look at this if you'd like.

tetsuo-cpp commented 1 year ago

Ok, so the issue was that in lift-x86-tests, we lift test functions from the lift-x86-tests binary itself. Because we're running the x86 tests with a 64-bit binary, we feed in 64-bit addresses which causes the TraceLifter to complain. I believe it was just luck up to now that the mask wasn't trimming any of the address when we were testing in the past.

The TraceLifter isn't used in Anvill or really anywhere else. It's just for testing and the remill-lift binary. Given that we do this check already in remill-lift here, I decided it probably makes sense to remove this check as it doesn't apply for testing.