Closed tetsuo-cpp closed 1 year ago
Sorry @ekilmer, I misunderstood what was going on earlier.
The issue was actually with the UBSAN patch to the sign_extend function and not the upstream commit itself. When https://github.com/NationalSecurityAgency/ghidra/commit/3c08b44a1e9e993bf0f5d4b87e20a66c0d049f3c landed, I had to regenerate the UBSAN patch but I botched the part of the patch that modifies sign_extend and introduced this bug.
sign_extend
Now that the UBSAN patch no longer touches this function, I should just get rid of the new patch and things should "just work".
Sorry @ekilmer, I misunderstood what was going on earlier.
The issue was actually with the UBSAN patch to the
sign_extendfunction and not the upstream commit itself. When https://github.com/NationalSecurityAgency/ghidra/commit/3c08b44a1e9e993bf0f5d4b87e20a66c0d049f3c landed, I had to regenerate the UBSAN patch but I botched the part of the patch that modifiessign_extendand introduced this bug.Now that the UBSAN patch no longer touches this function, I should just get rid of the new patch and things should "just work".