Open zachatrocity opened 1 year ago
Do the i10n and .g files have to be regenerated manually at the moment? If it generates/updates files for all languages I'd suggest it not be a precommit hook since it might clutter up individual commits (personally I prefer one language in the functional commit(s) and then the others a separate one), but that's a matter of preference from you guys as project owners.
.g files probably should get regenerated as a precommit hook, though, since that affects functionality.
I'd also suggest dart format
be in the precommit hooks. Usually stuff related to formatting/linting are precommit hooks in my experience, so that code gets committed with a consistent style. If it's a pre-push hook people will be adding additional commits to reformat when needed (like I just did with one of my PRs 😂)
Run dart format, analyze, test on a pre push hook.
Also should we generate i10n and build the .g files on pre commit?