search

liftoff / GateOne

Gate One is an HTML5-powered terminal emulator and SSH client
http://liftoffsoftware.com/Products/GateOne
Other
6.28k stars 925 forks source link

Popup messages appear too often #180

Open Gwindalmir opened 11 years ago

Gwindalmir commented 11 years ago

This is more of a feature request than a bug. It would be nice if we could control how often some of the messages appear. For example, I get this message scrolling by often: WARNING: The rate limiter was engaged on terminal 3. Output will be severely slowed until you press a key (e.g. Ctrl-C). In my case I'm running a compile on that terminal, so I'm fine with the limiter in place. However the message is on constantly with seemingly no way to turn it off or limit it, especially since it appears on all terminals.

Additionally, it's not clear if I press control-C to speed it up, if that is then sent to the terminal or not.

liftoff commented 11 years ago

Hmm.. I can see how that would be annoying. I'll see what I can do.

For reference, the Ctrl-C here is just given as an example of how you could slow the output of the underlying application (i.e. kill it). Simply typing any keystroke will disengage the rate limiter.

Gwindalmir commented 11 years ago

Thanks for looking into it. I noticed I can press any key, however I couldn't tell if that worked with Ctrl. I usually press Ctrl to trigger some interaction (like waking up the display) because 99% of the time it doesn't cause unintended side effects (by passing the key to the foreground application). So, does it send the keystroke to the terminal?

liftoff commented 11 years ago

Oh, actually... Not sure if pressing a modifier will work. Probably need to press a complete keystroke of some sort. Enter key is usually pretty harmless.

Gwindalmir commented 11 years ago

Also, I noticed that if I press a keystroke (in my case Ctrl-Z), it took at least 30 seconds for the remote end to respond to it. This is over an 18Mbps minimum fibre link on both ends with a 1ms ping (same fiber ISP).

liftoff commented 11 years ago

The reason why it takes so long to respond is because Gate One is still has to process all the output that's left in the buffer. Since the program was outputting a lot of data (the rate limiter needed to be engaged, after all) it can take a little while for that to finish up.

I'm always looking for ways to improve the rate limiter... If you know Python take a look at termio.py. I'm open to ideas!