liftoff / GateOne

Gate One is an HTML5-powered terminal emulator and SSH client
http://liftoffsoftware.com/Products/GateOne
Other
6.28k stars 925 forks source link

Bookmarks can be created but not edited or deleted #347

Open gr0undzer0 opened 10 years ago

gr0undzer0 commented 10 years ago

In the bookmark menu after you create a bookmark you can click edit but nothing happens. You can also delete it and the server reports

Deleting bookmark or marking it as such Syncronization complete.

However looking in ../users/user/bookmakrs.json the bookmark remains.

There are no errors to do with bookmarks in any of the logs so far as I see: The format of the bookmark looks fine:

[{"updated": 1384993598504, "name": "test", "created": 1384993598504, "url": "https://www.test.com", "notes": "", "tags": ["Untagged"], "visits": 0, "updateSequenceNum": 1, "images": {"favicon": null}}]

liftoff commented 10 years ago

I cannot reproduce this problem. What browser/OS are you using?

Also, what are the permissions on your user_dir? In the new package the user_dir ends up as /var/lib/gateone/users by default.

gr0undzer0 commented 10 years ago

Aurora /var/lib/gateone drwxr-xr-x gateone:gateone same with all folders beneath that. I run my service as user gateone.

On Wed, Nov 20, 2013 at 9:18 PM, Dan McDougall notifications@github.comwrote:

I cannot reproduce this problem. What browser/OS are you using?

Also, what are the permissions on your user_dir? In the new package the user_dir ends up as /var/lib/gateone/users by default.

— Reply to this email directly or view it on GitHubhttps://github.com/liftoff/GateOne/issues/347#issuecomment-28952733 .

Chris Jones RHCSA

liftoff commented 10 years ago

I've been meaning to try out Aurora. Downloading now...

gr0undzer0 commented 10 years ago

drwx------ gateone:gateone on users rwx gateone:gateone rw gateone:gatone

on the rest of the stuff

Now I tried it on normal firefox but i didn't create it on firefox so maybe...

liftoff commented 10 years ago

OK I just loaded up Aurora and everything worked fine: I was able to create/edit/delete/sync bookmarks without issues. I added tags, removed tags, dragged tags on to bookmarks (bet you didn't know you could do that =), etc etc.

Do you have an extension that is messing with JavaScript somehow? Maybe something that disables IndexedDB or localStorage?

It could also be a permissions problem in your Firefox profile directory... Which would be strange but not unheard of.

Does Chrome/Chromium work?

liftoff commented 10 years ago

Oh, any errors in the JavaScript console or anything like that? Any errors in your Gate One logs?

gr0undzer0 commented 10 years ago

I'll try it out within a few hours thanks and sorry if were going down a cold trail

Sent from my HTC

----- Reply message ----- From: "Dan McDougall" notifications@github.com To: "liftoff/GateOne" GateOne@noreply.github.com Cc: "Christopher Jones" christopher.donald.jones@gmail.com Subject: [GateOne] Bookmarks can be created but not edited or deleted (#347) Date: Wed, Nov 20, 2013 9:34 PM

OK I just loaded up Aurora and everything worked fine: I was able to create/edit/delete/sync bookmarks without issues. I added tags, removed tags, dragged tags on to bookmarks (bet you didn't know you could do that =), etc etc.

Do you have an extension that is messing with JavaScript somehow? Maybe something that disables IndexedDB or localStorage?

It could also be a permissions problem in your Firefox profile directory... Which would be strange but not unheard of.

Does Chrome/Chromium work?


Reply to this email directly or view it on GitHub: https://github.com/liftoff/GateOne/issues/347#issuecomment-28953318

gr0undzer0 commented 10 years ago

HAHAH i found out how you can repeat this bug!!

When you make the bookmark only fill out the url and the title. If you fill out the tags and comments you can edit it after its created. If not you can't touch it.

liftoff commented 10 years ago

OK I opened up Aurora and got all sorts of nonsense trying to create/edit bookmarks! I couldn't replicate your problem exactly but it definitely wasn't working properly (backspace key wasn't working inside the fields, for example). After troubleshooting for a bit I discovered the problem: The Web Developer Add-On.

I disabled Web Developer and like magic everything started working properly! I can create/edit/delete bookmarks with just a URL and a title.

Do you have the Web Developer Add-On installed? Also, I discovered this by examining the JavaScript console. Can you paste any errors you get from the console into this issue?

gr0undzer0 commented 10 years ago

I don't have web developer installed. Looking at the console I'm getting no errors What you will notice though .. and its as it should be I assume... that when it works it says 1 bookmarks were updated. Other then that there is no difference in output. Also I was able to replicate the problem at least once in chrome. Not sure if having created the orginal user profile with aurora effects it. I believe I even tried removing all the user profile and starting from chrome from scratch once. :

When I made test.com (this was created and i could edit it / delete it) POST https://10.0.0.25/bookmarks/fetchicon [HTTP/1.1 200 OK 408ms] 19:29:49.666 "2013-11-22 19:29:49 INFO Message: Synchronization Complete: 1 bookmarks were updated." gateone.js:2139

When I made a http://google.com with google in all fields it refreshed and has no google bookmark.

POST https://10.0.0.25/bookmarks/fetchicon [HTTP/1.1 200 OK 379ms] 19:31:24.935 "2013-11-22 19:31:24 INFO Message: Synchronization Complete" gateone.js:2139

Tried the same action again and the google bookmark was created and I could edit / delete it: POST https://10.0.0.25/bookmarks/fetchicon [HTTP/1.1 200 OK 348ms] 19:32:44.237 "2013-11-22 19:32:44 INFO Message: Synchronization Complete: 1 bookmarks were updated." gateone.js:2139

Tried to make http:test.com and did not put in a tag or comment after refresh the bookmark is gone POST https://10.0.0.25/bookmarks/fetchicon [HTTP/1.1 200 OK 428ms] 19:34:17.004 "2013-11-22 19:34:17 INFO Message: Synchronization Complete"

Tried to make google.com again .. included title as tag and test as comment the bookmark was created: POST https://10.0.0.25/bookmarks/fetchicon [HTTP/1.1 200 OK 368ms] 19:36:14.919 "2013-11-22 19:36:14 INFO Message: Synchronization Complete: 1 bookmarks were updated." gateone.js:2139