liftoff / GateOne

Gate One is an HTML5-powered terminal emulator and SSH client
http://liftoffsoftware.com/Products/GateOne
Other
6.28k stars 925 forks source link

Esc keypress of passed to server #544

Open lozbrown opened 9 years ago

lozbrown commented 9 years ago

Hi

I'm testing this application and all looks quite good apart from my Esc key presses do not seem to be passed to the server which makes vi usage very difficult.

I'm using IE11 as a browser (as is mandated by my employer)

Is there anything that can be done to fix this?

MatthiasKauer commented 9 years ago

same here; in normal vim Ctrl+] does the trick, but it's blocked in the demo as well. I'm using Firefox.

lozbrown commented 9 years ago

I'm actually using the full install on my server, the Ctrl+] combo doesn't seem to do much either

liftoff commented 9 years ago

Definitely a bug. It seems to work OK in Chrome but not Firefox. I'll fix it.

Note: I'll also make sure the Ctrl+[ combination works (which doesn't appear to work in Chrome either).

liftoff commented 9 years ago

After much testing I was able to determine that the only keystrokes that were not working in Firefox were the Ctrl-[ and Ctrl-] combinations. The escape key seems to be working properly. I was able to test this by running the cat command and pressing the escape key. It should look like this:

$ cat
^[ 

That's what I get when I test in Chrome and Firefox on my Linux desktop. Typing Ctrl-[ or Ctrl-] were not working in Firefox and I just pushed a commit to fix that. Can you folks grab the latest code and give it a try?

Also, what OSes are you experiencing this problem with?

lozbrown commented 9 years ago

Hi I use this for accessing my Ubuntu 15.4 home server from work so at work im testing this with IE11 on windows. I'll try and upgrade and retest before the end of the week...

liftoff commented 9 years ago

I'll see if I can boot up my Windows VM and give IE 11 a try (will take a while since I haven't booted it in ages).

lozbrown commented 9 years ago

Tested a fresh git clone this morning. Issue still remains

lozbrown commented 9 years ago

Is a fix for this possible? Is any more info required?