search

liftoffcli / liftoff

CLI for creating and configuring new Xcode projects
MIT License
1.6k stars 106 forks source link

Improve test target detection in xcodeproj_helper #251

Closed gfontenot closed 8 years ago

gfontenot commented 8 years ago

Now that we have customizable test target names, we can use that to detect test targets instead of just looking for the suffix "Tests".

Fixes #218 (finally)

jakecraige commented 8 years ago

Would you be able to add a test covering this?

gfontenot commented 8 years ago

I don't think so. This is so deep in the dumpster fire that is xcodeproj_helper.rb that I'm not sure how to get at this to test it.

gfontenot commented 8 years ago

If you have ideas on how to test this though, I'm all ears.

jakecraige commented 8 years ago

@gfontenot For a test I'd probably stub out the xcode_project method to return a stub of one and then test the 2 methods you modified work as expected.

gfontenot commented 8 years ago

that sounds like so much work

fine

jakecraige commented 8 years ago

carry on. private methods, le sigh.

gfontenot commented 8 years ago

Opened #254 to try and fix this