search

lifull-dev / bucky-management

Apache License 2.0
11 stars 12 forks source link

Revert "Merge pull request #29 from naotospace/master" #30

Closed rueyaa332266 closed 3 years ago

rueyaa332266 commented 3 years ago

This reverts commit 5e2db3d594c445ac2a2c121a81d0ee73cf7991cb, reversing changes made to 8eb4764d0a1969d5dc4a72684cc469a7bbff4989.

mi-shimizu commented 3 years ago

mimemagicのライセンス問題のようです（CIの失敗原因です） https://qiita.com/Wacci6/items/dc6ffec9b50578d44d6c

rueyaa332266 commented 3 years ago

@naotospace Revert first. https://github.com/lifull-dev/bucky-management/pull/30/commits/34bc2b38c6755d05c07207ee62fd58ec583bedf9

Then fix mimemagic problem by fixing gem version and install shared-mime-info https://github.com/lifull-dev/bucky-management/pull/30/commits/9a6263797e64dbd73aeed0c6e1002d8b2e5dd51a

Please review.

rueyaa332266 commented 3 years ago

Will fix in #31