lifuoliver / alufr-ros-pkg

Automatically exported from code.google.com/p/alufr-ros-pkg
0 stars 0 forks source link

RGBDSLAM services should not return before finishing work #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When calling a service, e.g. "rosservice call rgbdslam/ros_ui save_features" 
the service call returns immediately after the correspondig Qt signal is sent. 
This makes a script-like interaction with rgbdslam difficult, e.g. when you 
want to process the files that are created by a service call.
I suggest to add a signal that is emitted when the work has finished and 
waiting for this signal to arrive in RosUi::services*.
As I am interested in this behaviour I am willing to work on it to provide a 
patch.
Do you see any downsides?

Original issue reported on code.google.com by stephan....@gmail.com on 16 Jul 2012 at 12:34

GoogleCodeExporter commented 8 years ago

Original comment by h...@informatik.uni-freiburg.de on 16 Jul 2012 at 12:56

GoogleCodeExporter commented 8 years ago
I fixed this for the new release, for which there is no puplication schedule 
yet however. It can be easily done as in the attached diff. Note that the 
differences in graph_mgr_io.cpp are found in graph_manager.cpp in the current 
version (at different line numbers of course).
Summed up:
- new parameter for io concurrency which controls:
- the type of signal-slot direction "directConnection" 
Blocking/"autoConnection" (possibly non-blocking)
- whether io operations are done in background threads.

Original comment by end...@tf.uni-freiburg.de on 16 Jul 2012 at 3:13

Attachments: