search

ligasgr / intellij-xquery

Plugin to support XQuery in Intellij Idea
Apache License 2.0
35 stars 23 forks source link

Upgrade to BaseX 8.4.3 and BaseX XQJ driver 1.6.0 #191

Closed zyv closed 8 years ago

zyv commented 8 years ago

Hi there,

In the spirit of #120, I propose to upgrade the XQJ driver for BaseX to the latest version. To be really honest, I don't have a good reason to justify the upgrade, other than bugfixes that have flown into BaseX since the last upgrade, but I've done the work and tested the resulting plugin against the latest IDEA, so I thought I could just as well submit a pull request.

On a related note, I have found out during my testing, that, very unfortunately, BaseX XQJ driver still doesn't support XQuery 3.0, so this upgrade isn't solving the issues I was hoping to get at. It seems that at this point, the only way to use XQuery 3.0 features is to go for BaseX vendor API:

https://mailman.uni-konstanz.de/pipermail/basex-talk/2016-April/010468.html

I have worked around the problem by opting to create Run configurations via the BashSupport plugin, completely bypassing your run mechanisms, but that's suboptimal to say the least.

Do you think you could implement the vendor API, if yes, shall I open an issue for it? Unfortunately, I can't offer a pull request for this feature myself due to the time constraints.

Many thanks!

zyv commented 8 years ago

Sorry, I have forgotten to add the new files in the first commit.

ligasgr commented 8 years ago

Hi,

Thanks for contributing these changes. Can you please add yourself to CONTRIBUTORS file as part of the pull request (following the existing format of the file)? I'm considering adding native clients for all of the implementations over time as XQJ is quite slow with regards to upgrading to newer standard versions (3.0, 3.1, etc). I can't promise any timelines though.

Thanks, Grzegorz

zyv commented 8 years ago

Can you please add yourself to CONTRIBUTORS file as part of the pull request (following the existing format of the file)?

Done!

I'm considering adding native clients for all of the implementations over time as XQJ is quite slow with regards to upgrading to newer standard versions (3.0, 3.1, etc).

Great, I've filed #192 to track this. In the mean time, I'll go the BashSupport route...

Thanks!