Inspection - unused variable - Githubissues

ligasgr / intellij-xquery

Plugin to support XQuery in Intellij Idea

Apache License 2.0

35 stars 23 forks source link

Inspection - unused variable #97

Closed arnostv closed 10 years ago

arnostv commented 10 years ago

Closes #21

First pull request for this change was in #90. This is second attempt, with some improvement done

better names of sample functions in tests
smaller better named functions in UnusedVariableFinder
added some additional support for variable defined in for clause of FLWOR expression

Not supporting global private variable yet - possible in another commit/another issue.

buildhive commented 10 years ago

ligasgr » intellij-xquery #69 SUCCESS This pull request looks good (what's this?)

ligasgr commented 10 years ago

Can you please prepare a nice description of the inspection analogous to src/main/resources/inspectionDescriptions/UnusedImports.html? Right now the description of the inspection if you get into details is "Under construction" (ctrl-f1 pressed twice when cursor is on unused variable).

buildhive commented 10 years ago

ligasgr » intellij-xquery #74 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

ligasgr » intellij-xquery #75 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

ligasgr » intellij-xquery #76 FAILURE Looks like there's a problem with this pull request (what's this?)

ligasgr commented 10 years ago

Failing test has been marked as ignored due to resource loading issues when multiple xqj drivers on the classpath. Please rebase pull request.

buildhive commented 10 years ago

ligasgr » intellij-xquery #79 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

ligasgr » intellij-xquery #80 FAILURE Looks like there's a problem with this pull request (what's this?)