search

ligato / sfc-controller

Service Function Chain (SFC) Controller for stitching virtual and physical networking
Apache License 2.0
44 stars 29 forks source link

Fix some bugs & Change the glide app install way #28

Closed Jingzhao123 closed 5 years ago

Jingzhao123 commented 5 years ago

In this patch, it will resolve 2 problems.

  1. The sfc-controller image of alpine version builds failure. It needs to update the golang build version from 1.9 to 1.11.

  2. The alpine sfc-controller multi-arch image can not be build. This issue is caused by that the arm64 platform is not well supported by glide installalation shell scrpts. So it will be installed from source code.

Signed-off-by: Jingzhao Jingzhao.Ni@arm.com

Jingzhao123 commented 5 years ago

@jhnbrns Is there anybody who can update the ci scripts from golang 1.9 to 1.11 ?

stanislav-chlebec commented 5 years ago

https://github.com/ligato/sfc-controller/pull/30 I came accros the same problem. Maybe we could preserve the glide installation for x86_64 platform: https://github.com/ligato/sfc-controller/pull/30/commits/ad3a13e56524390a79cd811ddbe0b0e208606f2a

Jingzhao123 commented 5 years ago

Good idea !