search

ligato / vpp-agent

⚡️ Control plane management agent for FD.io's VPP
https://docs.ligato.io/
Apache License 2.0
247 stars 127 forks source link

feat: Model rework #1925

Closed pemoticak closed 1 year ago

pemoticak commented 1 year ago

This PR unifies remote registry and local registry into one structure containing all models directly. Remote and local models are also unified into one structure - knownModel. Handling of some properties (e.g. model name template) still depends on whether the model has a go type or not (it has a go type if the model was registered as a message from compiled .pb.go file, else if it was registered as a dynamicpb.Message it lacks a go type) but this could be eliminated in the future more easily then previously. It also adds proto extension that can be used to embed model specification and name template directly into .proto files. These changes make it possible to register models during vpp-agent startup directly from provided .proto files if desired. Ability of agentctl command to operate with models without go type is improved as well.

Signed-off-by: Peter Motičák peter.moticak@pantheon.tech

fgschwan commented 1 year ago

CI proto check is failing (https://github.com/ligato/vpp-agent/actions/runs/4828274020/jobs/8601897603?pr=1925)