search

ligershark / CoreTemplatePack

A collection of .NET Core project templates
Other
82 stars 17 forks source link

.gitignore contains files in wwwroot/dist which will not be automatically be created #21

Open SamJost opened 7 years ago

SamJost commented 7 years ago
  1. Create a new Project with the angular 2 spa template
  2. check the project into git
  3. clone the git repo in a new directory
  4. try to rebuild/run will not work because some files are missing: wwwroot/dist/89889688147bd7575d6327160d64e760.svg wwwroot/dist/vendor.css wwwroot/dist/vendor.js

The error message fails to load the web page due to missing wwwroot/dist/vendor-manifest.json file.

Probably these files should not be excluded from git by using .gitignore?

SteveSandersonMS commented 7 years ago

It's up to you. Since those a build artifacts, it's normal not to commit them into source control.

SamJost commented 7 years ago

When they are created, yes, they should be ignored. But for some reason they do not get created when I check out the project and open it in VS.

SteveSandersonMS commented 7 years ago

They are created when running webpack, which is best thought of as being part of building the project (though it's not wired into the build process as far as MSBuild is concerned, because often you'd want to build .NET code independently and not wait for a webpack build).

SamJost commented 7 years ago

Ok, so maybe it just needs some documentation how to build those after checking out a project? I still don't understand really what needs to happen so these will be build. They are updated even though I don't run webpack manually, so if it is not a buildstep, what is the magic glue running webpack?

icsimlai commented 6 years ago

Just wondering why there was no response on the question asked by SamJost. Needs some documentation please...