Minification broken for Bootstrap Javascript due to a NUglify issue - NUglify update needed

ligershark / WebOptimizer

A bundler and minifier for ASP.NET Core

Apache License 2.0

753 stars 113 forks source link

Minification broken for Bootstrap Javascript due to a NUglify issue - NUglify update needed #217

Open Daeymon opened 2 years ago

Daeymon commented 2 years ago

Minification currently is broken if a javascript bundle includes Bootstrap. This is a NUglify issue which has been resolved in release 1.17.8 (https://github.com/trullock/NUglify/issues/279).

Could you update the version of NUglify that WebOptimizer uses so WebOptimzer gets the fix?

Tim-Andersen commented 2 years ago

I believe I'm also seeing this issue when including the Bootstrap bundle JS file for minification, and concur with @Daeymon--would very much like to see WebOptimizer pull in the fix from NUglify. Thanks!

oh-yeah commented 1 year ago

Same issue here. I had to install NUglify version 1.20.2 in order to properly minify the CSS of Bootstrap 5.2.3.

htodep commented 1 year ago

Having the same issue. Getting a error inside the bundle at the top, nothing is broken. /* input(13224,6894-6927): run-time error JS1292: Strict-mode does not allow duplicate property names: ...o(e)?H.getDataAttributes(e):{} input(13224,6928-6954): run-time error JS1292: Strict-mode does not allow duplicate property names: ..."object"==typeof t?t:{} */

Versions:

Bootstrap v5.3.0-alpha3 js bundle file.
Ligershark Weboptimizer 3.0.384

mmarinchenko commented 11 months ago

Should be fixed by #280.