search

ligershark / WebOptimizer

A bundler and minifier for ASP.NET Core
Apache License 2.0
753 stars 113 forks source link

change to concurrent dictionary #229

Closed jasonliao-cb closed 2 years ago

jasonliao-cb commented 2 years ago

this is for issue https://github.com/ligershark/WebOptimizer/issues/228

daneSchilling commented 2 years ago

I was able to replicate similar issues by running parallel tasks racing to make the first request to GenerateCacheKey on a single instance of Asset. With the change above, I am able to run parallel tasks without issue.

With the tests I created, I was getting NullReferenceException on the code: asset.Items[PhysicalFilesKey] = files;

daneSchilling commented 2 years ago

@jasonliao-cb I would love for this to get merged. Maybe add the author as the reviewer? They may ask you to remove the unrelated gitignore changes. Thanks again for opening the PR!

madskristensen commented 2 years ago

Thanks

daneSchilling commented 2 years ago

Thank you!

exileDev commented 1 year ago

@madskristensen Can you publish the latest version?

madskristensen commented 1 year ago

Yes, releasing now...