ligershark / side-waffle

A collection of Item- and Project Templates for Visual Studio
Other
657 stars 205 forks source link

Allows for distinguishing between project and item templates in GA #325

Closed codewithtyler closed 8 years ago

codewithtyler commented 8 years ago

@sayedihashimi once we merge this in we'll need to update SideWaffle to include the new TemplateType custom parameter so it gets added automatically when someone adds a new template to SideWaffle.

sayedihashimi commented 8 years ago

@sayedihashimi once we merge this in we'll need to update SideWaffle to include the new TemplateType custom parameter so it gets added automatically when someone adds a new template to SideWaffle.

What do you mean?

codewithtyler commented 8 years ago

For example let's say I add a new template to SideWaffle. From what I understand in our previous conversations when I add the template the wizard will get added to my vstemplate file so that we can track it as well. We'll need to update whatever adds that wizard so it has the new TemplateType custom parameter.

sayedihashimi commented 8 years ago

@RandomlyKnighted If I understand you right you're suggesting that we add the telemetry wizard entries into the template files for project templates and item templates.

Those templates are used by people adding templates to SideWaffle as well as people creating their own template packs. Because of that I don't think it's a good idea to add the wizard entries to those templates.

Instead what I think we should do is.

  1. [ ] Update the build script to check each template has telemetry values, and if missing fail the build. Since we have builds executing for PRs this will be helpful for SideWaffle
  2. [ ] Update the wiki to instruct people to add these values when contributing to SideWaffle
codewithtyler commented 8 years ago

Perfect! If you'll update the build script then I'll update the wiki article.

sayedihashimi commented 8 years ago

@RandomlyKnighted ok great, I have created the following issues

codewithtyler commented 8 years ago

We'll need to do this for regular templates ( not just multi project templates) as well correct?