search

ligershark / sidewafflev2

Other
30 stars 11 forks source link

Remove .template.config folder from project if Template Info Dialog Cancel clicked #10

Open shaggygi opened 7 years ago

shaggygi commented 7 years ago

I noticed if you click Cancel button in Template Info Dialog, the files will still remain in the project. It would be nice to remove them. If not, it might be a good idea to document somewhere what was added to let the dev know what needs to be removed manually (especially since there are hidden files added during the process).

sayedihashimi commented 7 years ago

Hi @shaggygi thanks for the issue. If you Cancel the dialog then the files should not be getting created on disk. I noticed that the .template.config directory was always getting created. I made changes in 52b206126a6166f775a42c410a41178037cd4304 to prevent creation of the folder on Cancel as well.

Are you seeing some different behavior where the files are created on Cancel?

shaggygi commented 7 years ago

@sayedihashimi Sorry for delay. I verified and you are correct. The hidden .template.config folder is created, but not the files. I'll update issue title. Thx

sayedihashimi commented 7 years ago

In the latest bits (not released yet) I already fixed the folder creation issue. The commit is linked above.

codewithtyler commented 6 years ago

@sayedihashimi has this fixed been released?

sayedihashimi commented 6 years ago

@tylerbhughes I think so, but not totally sure.

codewithtyler commented 6 years ago

@sayedihashimi I've tested and confirmed that the .template.config file does not get deleted if you click the cancel button.