search

light-ripple / Ripple-Auto-Installer

OSU! Ripple Stack Installation Helper
https://ripple.moe
GNU Affero General Public License v3.0
20 stars 9 forks source link

Add Tmux Script #152

Closed LiveEmily closed 3 years ago

loannaflip commented 3 years ago

@LiveEmily Fix the issue(s) reported by CodeFactor.

loannaflip commented 3 years ago

@LiveEmily take a look at https://github.com/LiveEmily/Ripple-Auto-Installer/blob/master/Main/tmux.sh#L10 /root/liveemily/. that's your username which won't apply to everyone else

loannaflip commented 3 years ago

@LiveEmily Why are you using TASK=... for? they're not being used later anywhere else.

Mar0xy commented 3 years ago

Think about replacing /root/liveemily with $home

loannaflip commented 3 years ago

@LiveEmily Create a new pull request with proper commit, commit message and PR label.