search

lightSAML / SpBundle

SAML2 SP Symfony Bundle based on LightSAML
https://www.lightsaml.com/SP-Bundle/
MIT License
66 stars 70 forks source link

Add new pre-commit hook. #1

Closed BernardoSilva closed 8 years ago

BernardoSilva commented 8 years ago

Hi Milos,

Created a new way of sharing git-hooks across all php-projects.

Created a PR to get some feedback from you.

The idea is with just one dependency set git hooks without having to configure anything else.

This will also allow you to use the exact same hooks on all different projects without any effort and all contributors will have the same.

tmilos commented 8 years ago

Scrutinizer failed with some dependencies, not sure why, when travis passed... Have retried it now... Will see Other thing that catch my eye is your GPL3 license... Not sure how that is compatible with MIT license. It's doing some magic with composer I'm not familiar with. Have to see trough, can not merge this right now.

BernardoSilva commented 8 years ago

@tmilos Updated license to MIT. Think I've solved the dependency problem in Scrutiniser. Just want to help all open source projects with this git-hooks-php package, MIT makes it easier. :)

tmilos commented 8 years ago

Sorry @BernardoSilva but some people are against "fiddling with their Git configuration", think we won't add this: https://github.com/lightSAML/lightSAML/pull/3

cc @cb8