search

lightSAML / SpBundle

SAML2 SP Symfony Bundle based on LightSAML
https://www.lightsaml.com/SP-Bundle/
MIT License
66 stars 70 forks source link

Ability added to provide a custom token factory #10

Closed iainmckay closed 8 years ago

iainmckay commented 8 years ago

We're trying this bundle and our app requires a specific auth token to be created. This PR adds the ability to provide a custom token factory.

iainmckay commented 8 years ago

Thank you for fixing the failing tests. I was in the process of fixing them :)

tmilos commented 8 years ago

Sure, no problem, thank you for contributing. I made a small change to the factory, removed the SamlSpTokenInterface you added since it wasn't really used, and depend on Symfony's TokenInterface. Guess that suites your needs, you can use which ever token class you want. In the yet to be written logout bundle we would need NameID and SessionIndex, but think they can be stored in token attributes.

tmilos commented 8 years ago

Btw, feel free to add yourself to the CONTRIBUTORS.md file

iainmckay commented 8 years ago

Sure, that works for me.