search

lightSAML / SpBundle

SAML2 SP Symfony Bundle based on LightSAML
https://www.lightsaml.com/SP-Bundle/
MIT License
66 stars 70 forks source link

Adding checkPreAuth before authenticating #31

Closed rudott closed 7 years ago

rudott commented 7 years ago

@tmilos In the old repository there was a PR for adding the checkPreAuth, is it possible to add this feature, because I think it would be necessary for extra security checks. https://github.com/aerialship/SamlSPBundle/pull/44/files

By adding this check it's possible to add the default checks isAccountNonLocked, isEnabled & isAccountNonExpired by using the AdvancedUserInterface.

Should I create a PR for this (including the missing test)?

Thank you!

tmilos commented 7 years ago

Yes please make the PR. I guess it should be placed right above existing checkPostAuth call since authentication actually is not really done internally by the system, but relays on the received assertions.

rudott commented 7 years ago

@tmilos thanks for your quick reply. I created the PR: https://github.com/lightSAML/SpBundle/pull/32

tmilos commented 7 years ago

Merged and released in v1.0.3 Thanks