search

lightbasenl / react-native-panorama-view

A simple component for displaying panoramic images in your React Native app.
MIT License
127 stars 47 forks source link

fix iOS build with updated RN versions. #67

Closed cristianoccazinsp closed 2 years ago

cristianoccazinsp commented 2 years ago

Fix a build issue with RN > 0.62 on IOS. Fixes https://github.com/lightbasenl/react-native-panorama-view/issues/60

Cleaned up bad spaces as well.

The implementation is slightly different as the one recommended in the issue, in order to prevent a crash by using !

guard let request = RCTConvert.nsurlRequest(imageUrl) else {
                    return
                }
rodymolenaar commented 2 years ago

LGTM!

cristianoccazinsp commented 2 years ago

Would you please merge and release? Thanks!