search

lightbasenl / react-native-panorama-view

A simple component for displaying panoramic images in your React Native app.
MIT License
130 stars 48 forks source link

Android support for grade 7^ #89

Open can019 opened 2 years ago

can019 commented 2 years ago

A build error occurs in Gradle 7.3. There seems to be an error related to maven, so I hope the problem is solved. In particular, among the panarama views supported by react native, this library is considered the only stable. I really hope it's resolved.

rjsdn0124 commented 2 years ago

I have same problem too.......

BryanJosue98 commented 1 year ago

Pls fix this issue :c

mikson7 commented 1 year ago

Did anyone figured out how to fix this issue?

VahanAper commented 1 year ago

@rodymolenaar could you please find a spare moment to fix this. A lot of people depend on it. Would be really appreciated.

nadein commented 1 year ago

I also had an error with maven in build.gradle script (@lightbase/react-native-panorama-view/android/build.gradle). If was fixed by changing apply plugin: 'maven' to apply plugin: 'maven-publish'

After this change and Gradle sync I faced a new issue with error message:

Configuration with name 'compile' not found.

It is caused by next line: classpath += files(project.getConfigurations().getByName('compile').asList()) Because compile configuration was deprecated and removed. It's now implementation.

After updating compile -> implementation I ran another sync and got message:

Resolving dependency configuration 'implementation' is not allowed as it is defined as 'canBeResolved=false'. Instead, a resolvable ('canBeResolved=true') dependency configuration that extends 'implementation' should be resolved.

So I tried to add custom configuration

configurations {
    customConfig.extendsFrom implementation
}

And updated the line classpath += files(project.getConfigurations().getByName('customConfig').asList()) So it leads to more errors with react-native can't be resolved etc.

So the component needs to be updated to support modern versions of Gradle. I'm not an expert in Gradle/Android/React Native so it's just a thoughts and suggestions.

Update: I tried update from this PR: https://github.com/lightbasenl/react-native-panorama-view/pull/77 And it fixed all issues. I think it must be approved and merged by maintainers. @rodymolenaar @cristianocca

daviseares commented 7 months ago

jcenter is down. So we cant make works on android. :/