lightbeam24 / CustomTube

Choose your own YouTube layout, plus some other settings!
MIT License
109 stars 10 forks source link

Subscriber Groups button are inaccessible/unclickable or glitched in every of layouts with PocketTube #13

Open Aleksandra0056 opened 1 year ago

Aleksandra0056 commented 1 year ago

Problem description:

Expected results:

Other details:

Screenshots:

image

lightbeam24 commented 1 year ago

I haven't used PocketTube, but based on your screenshot, it looks like PocketTube is creating its own sidebar elements that use separate styling from the native YouTube sidebar items. So basically this only happens because CustomTube wasn't tested with PocketTube. (The only other extensions/scripts CustomTube was tested with are uBlock Origin and Return YouTube Dislike.)

I'll look into it though. In the meantime, could you tell me if it happens on other layouts? In this situation, it would be most helpful to test on the 2013, 2017, and 2019 layouts. If it happens on all three of those layouts, test it with "Layout Select" set to "Disabled".

Aleksandra0056 commented 1 year ago

In the 2013, the PocketTube is not only inaccessible, but also large, and the “Deck” button has an icon, and also under some icons there are grey YouTube buttons underneath them (Wait for me to test the 2017, and 2019 please…) image

Aleksandra0056 commented 1 year ago

2014 PocketTube is clickable, but the buttons are large, and “Deck” button is misaligned (Not unclickable, sorry), and Deck have bad outline (Sorry, but you must wait, because I have some things to do with Firefox's CSS, so be patient…): image

Aleksandra0056 commented 1 year ago

Well, 2015 is same as 2014. (Sorry for delay, but I changed some CSS files in my Firefox (Which are unrelated to this issue))

Aleksandra0056 commented 1 year ago

2016 is ditto as 2015, and 2014.

2017 is also the same.

lightbeam24 commented 1 year ago

Yeah 2014-2017 should all be the same, there isn't much of a need to test them all. They share most of their code, excluding the watch page.

Aleksandra0056 commented 1 year ago

And for 2019, then there is wrong outline shade for Deck button, and the Sub. Collections are using wrong buttons shape, they should be square instead of rounded. (And Sub. Collections are clickable/accessible!)

image

lightbeam24 commented 1 year ago

Okay, so that adds weight to my theory that PocketTube uses it's own CSS to style its sidebar items. I'll look into fixing it.

Aleksandra0056 commented 1 year ago

Please, I need your answer, is this blue tick mark feature of YouTube, or feature of PocketTube? image

lightbeam24 commented 1 year ago

I don't have that blue checkmark, so it must be PocketTube.

Aleksandra0056 commented 1 year ago

Fine, I will write it to description, and title.

UPDATE: It is right in description. Not title for now, because I don't have any idea how the title should be written with more things.