search

lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

Work on dbuild 0.9.0, dist #113

Closed cunei closed 10 years ago

cunei commented 10 years ago

Improvements to the "dist" project. The launcher is now packaged as a regular artifact, and can be easily uploaded to Artifact together with all the rest. To create a release, just use "^release".

jsuereth commented 10 years ago

Generally LGTM and can be merged. A few comments, I'm always a fan of release.

Primarily:

  1. I think there may be a caching issue which is forcing you to have to clean. We may want to open corresponding tickets otherwise, or you may need to clean the sbt-launcher grabbing code as Havoc has done/is doing in sbt-remote-control.
  2. This reminds me that we should probably be aggressively moving to 2.10 in the next quarter (or 2.11) for the core of dbuild, and try to limit the sbt-plugin sections, as well as move your own build to 0.13.

IN any case, great work here! Merge when you feel you've addressed any comments (I had an Idea on the dynamic dependency discovery with clean task.