lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

Ready for 0.9.1 #121

Closed cunei closed 10 years ago

cunei commented 10 years ago

It turns out that one of the last few commits in 0.9.0 may cause a repository consistency check failure on occasion. That is due to the default value of the new "settings" option, which once serialized and deserialized will appear with a different value (from List() to List(List())), hence a different sha. This pull request addresses this issue for a hotfix 0.9.1, and also adds much better cycle diagnostic, which is now actually useful to understand immediately what is going on, as in the following example.

[error] These items are part of cycles, and are all reachable from each other:
[error]    Project "scalariform-210" uses com.typesafe.sbteclipse:sbteclipse-plugin:jar, which is provided by: "sbteclipse".
[error]    Project "scalariform-210" uses com.typesafe.sbt:sbt-scalariform:jar, which is provided by: "sbt-scalariform".
[error]    Project "sbt-scalariform" uses org.scalariform:scalariform:jar, which is provided by: "scalariform-210".
[error]    Project "sbteclipse" uses com.typesafe.sbt:sbt-scalariform:jar, which is provided by: "sbt-scalariform".
jsuereth commented 10 years ago

LGTM, subtle issue.