search

lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

dbuild uses `name` in duplicates checking, should be `moduleName` #188

Closed SethTisue closed 7 years ago

SethTisue commented 8 years ago

this came up in the community build, where I couldn't build Cats because dbuild complained that both Cats and macro-compat produced org.typelevel#core (which they don't)

details at https://github.com/typelevel/cats/issues/1396 (I had initially thought the problem was on the Cats side)

dwijnand commented 8 years ago

Perhaps instead of moduleName it should be whatever becomes the artifactId in the POM.

This would allow, as an example, dbuild to not fail when seeing both a cats-core for JVM and a cats-core for JS, by seeing them as org.typelevel#cats-core_2.11 and org.typelevel#cats-core_sjs0.6_2.11 instead.

SethTisue commented 7 years ago

I opened a separate ticket (#193) on the Scala.js angle here.

cunei commented 7 years ago

@SethTisue The duplicate checking is technically done, according to the suggestion, so this issue should be solved. I spoke with @dwijnand concerning Scala.js, and the issue there is different (see comment in #193)