search

lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

Don't checkMissing when fixing dependencyOverrides #227

Closed dwijnand closed 4 years ago

dwijnand commented 4 years ago

When fixing overrides, I see very little need to bomb with "checkMissing". You can still emit all the warnings and everything, but just don't bomb. If the dependency is also in allDependencies, then it'll still bomb.

This is relevant because there's a dependencyOverrides on scripted-plugin since sbt 1.2, which blows up in fixModule.

Alternative to #226. @cunei what do you think?

dwijnand commented 4 years ago

I'm less sure about this fix because the sbt 1.2+ new ScriptedPlugin AutoPlugin (yeah, lol) adds scripted-sbt_2.12 to libraryDependencies, which as you see is cross-built, so would explode...

https://repo1.maven.org/maven2/org/scala-sbt/scripted-sbt_2.12/