lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

Resolve scala-xml version conflict (1.x vs 2.x) with sbt 1.8.0 #232

Closed SethTisue closed 1 year ago

SethTisue commented 1 year ago

I have tried to work around this but failed, so it may finally be time to roll a new dbuild version.

SethTisue commented 1 year ago

To update it, I'll have to figure out where the scala-xml 1.x dependency even is... it must be indirect

SethTisue commented 1 year ago

Maybe I don't need to update the dependency. Maybe I just need to figure out where to inject libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % VersionScheme.Always

SethTisue commented 1 year ago

oh, the dependency is coming in through dispatch :

[cloc-plugin] [error]   * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over {1.0.6}
[cloc-plugin] [error]       +- org.scala-lang:scala-compiler:2.12.17              (depends on 2.1.0)
[cloc-plugin] [error]       +- net.databinder.dispatch:dispatch-core_2.12:0.12.2  (depends on 1.0.6)
SethTisue commented 1 year ago

merged #238, but leaving this open until I've tried it in the Scala 2 community build

SethTisue commented 1 year ago

238 didn't work... maybe #239

SethTisue commented 1 year ago

it's also tempting to just replace the dependency on dispatch with something else... I could consider that if #239 doesn't work out

SethTisue commented 1 year ago

trying it at https://github.com/scala/community-build/pull/1619

SethTisue commented 1 year ago

it works!