search

lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

Wip/play2 #5

Closed jsuereth closed 11 years ago

jsuereth commented 11 years ago

Features Peter added for Play2 + fixes to hash consistency that was leading to sbt builds not having repeatable SHA UUIDs.

Note: The hashing functions for case classes remain somewhat flaky and tied to our current case class design. Altering case classes ruins the UUID and the entire cache repository. This is actually kind of nice, in that altering the metadata format leads to the formation of new metadata in the repository, and the artifacts should not need to be cached again if they remain the same bytewise.

however there should be warning flags, bells and possible a guardian dragon around that portion of the design until we figure out a more stable way to compute bytewise UUID.

Review by @pvlugter and @harrah

pvlugter commented 11 years ago

Generally looks good.

Great to have the project specific repositories! Haven't had a chance to look more closely at these in action.

Does this branch build play now? I tried running ActorMain.runBuild but it failed on one of the earlier builds (sperformance) in the sbt builder with "Failed to generate or load build results!".

jsuereth commented 11 years ago

No. Play doesn't build yet. Still wip. The project filtering is still busted, and I need to set up a better debugging environment.

jsuereth commented 11 years ago

Cool, I'm going to merge this now then and fix up project selection later.