search

lightbend-labs / dbuild

Multi-project build tool, based on sbt.
https://lightbend-labs.github.io/dbuild
Other
83 stars 14 forks source link

New feature: binary comparison #91

Closed cunei closed 10 years ago

cunei commented 10 years ago

If spaces are used to bootstrap something, by building the same projects in subsequent stages, it may be useful to verify that the generated artifacts are the same in the different stages. This pull request adds a new "comparison" feature, that can be used to compare automatically artifacts from different projects at the end of compilation.

adriaanm commented 10 years ago

Very interesting! I'll try to look into this before our meeting tomorrow. Oh, I just checked, @jsuereth, I don't see it in my calendar.

jsuereth commented 10 years ago

Interesting feature. I'd like to rethink the name while we have an opportunity. While "stability' makes sense from a "build multiple times" standpoint, I think "binary diff" may be more accurate description of the current feature.

Also, I feel like the JAR comparison you have in there belongs in, at the minimum, its own object and at a maximum its own project.

cunei commented 10 years ago

The jar comparison is now in a different object, and the task has been renamed "Comparison".

cunei commented 10 years ago

The pull request should be ok for merging, now.

jsuereth commented 10 years ago

This LGTM. Can merge. For some reason github thinks it's not mergable.