search

lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
170 stars 23 forks source link

Add sbt-github-actions and sbt-ci-release #152

Closed mdedetrich closed 10 months ago

mdedetrich commented 10 months ago

Resolves: https://github.com/lightbend-labs/jardiff/issues/132

Adds sbt-github-actions and sbt-ci-release.

Note that this doesn't automate adding the assembly jar to github release notes (see https://github.com/lightbend-labs/jardiff/issues/151#issue-1970725192). I guess this can be automated via the likes of https://github.com/ohnosequences/sbt-github-release but it seems to be dead and I can't find prior art on how this is done with other projects?

Another thing is that I have added windows/mac to the testing matrix to make sure it works on all platforms.

@SethTisue

mdedetrich commented 10 months ago

And low and behold, managed to find out that this project doesn't work under windows (see https://github.com/lightbend-labs/jardiff/actions/runs/6711737556/job/18239778005?pr=152). @SethTisue should I add another commit to fix, or fix it in another PR?

SethTisue commented 10 months ago

Note that this doesn't automate adding the assembly jar to github release notes

I believe that was just a poor man’s substitute for proper publication and we don't need to keep doing it.

should I add another commit to fix

sure, that's fine, doesn't need to be a separate PR (we're pretty strict in scala/scala but not so much in other repos)

mdedetrich commented 10 months ago

@SethTisue So I have decided adding Windows support is not worth it and its better to resolve this in another PR. I just made https://github.com/lightbend-labs/jardiff/issues/153 to track it.

Feel free to merge if there isn't anything else additional required.

SethTisue commented 10 months ago

Thank you, Matthew! Much appreciated.

I've opened #154 to test this, but I won't get to it today.

SethTisue commented 10 months ago

Note that this doesn't automate adding the assembly jar to github release notes

I believe that was just a poor man’s substitute for proper publication and we don't need to keep doing it.

On second thought, as it stands we do need to keep doing it, because you've set it up so the CLI jar isn't published to Maven Central. So I left it in RELEASING.md.

I would have been fine (would still be fine) with publishing both JARs to Maven Central 🤷