search

lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
170 stars 23 forks source link

Add Windows support #153

Open mdedetrich opened 10 months ago

mdedetrich commented 10 months ago

scala.tools.jardiff.IOUtilSpec is failing on Windows and it appears that scala.tools.jardiff.IOUtil.rootPath needs to be changed so its Windows aware, see https://github.com/lightbend-labs/jardiff/pull/152#issuecomment-1787942573

He-Pin commented 10 months ago

I'm using windows, and I can take a look at this one.

SethTisue commented 9 months ago

@He-Pin any luck?

SethTisue commented 9 months ago

@mdedetrich this isn't a regression, is it?

mdedetrich commented 9 months ago

@mdedetrich this isn't a regression, is it?

Afaik it's not a regression, it just never worked on Windows

som-snytt commented 2 months ago

I also never worked on Windows.