lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
170 stars 23 forks source link

Roll another release, to be sure sbt-ci-release is working #154

Closed SethTisue closed 9 months ago

SethTisue commented 10 months ago

now that #152 by @mdedetrich is merged, let's make sure we can use it

first, I'll need to add publishing secrets to the GitHub Actions config

mdedetrich commented 10 months ago

@SethTisue Now that I think about it can you hold off the patch release until https://github.com/lightbend-labs/jardiff/issues/155 is done? I will try and do it tomorrow (shouldn't be too hard) but the reasoning is that currently its publishing cli related stuff along with Main which doesn't make sense

SethTisue commented 10 months ago

sure, fine with me. see also #156

SethTisue commented 10 months ago

158 adds release steps to the repo (RELEASING.md)

SethTisue commented 10 months ago

@mdedetrich I added the secrets (using my personal Sonatype account, which has permissions for com.lightbend publishing)

SethTisue commented 10 months ago

after publishing, I'll need to revise https://github.com/retronym/homebrew-formulas/pull/5

SethTisue commented 9 months ago

@mdedetrich I can't remember where I left off on this. Like was I waiting for something else to happen? If you can't think of anything that's still pending, I guess I should try to push a tag? (There was #153, but since it hasn't progressed, maybe we should release anyway and figure on releasing again if a fix comes in.)

mdedetrich commented 9 months ago

Yeah I was actually expecting a release at some point, the Windows fix can wait

SethTisue commented 9 months ago

(release steps from RELEASING.md)

Core JAR

CLI jar

SethTisue commented 9 months ago

@mdedetrich no publish job was triggered. there must have been a flaw in https://github.com/lightbend-labs/jardiff/pull/152 ? is it obvious to you what went wrong here?

I'm not used to a setup with everything in ci.yml — all the repos I work on have separate ci.yml and release.yml. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself

som-snytt commented 9 months ago

🎶 Please release me, let me go 🎶

mdedetrich commented 9 months ago

@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here?

I'm not used to a setup with everything in ci.yml — all the repos I work on have separate ci.yml and release.yml. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself

Did you push a tag? Pushing a tag with the vx.x.x pattern is what forces a publish and judging from https://github.com/lightbend-labs/jardiff/tags the last tag was pushed 2 weeks ago?

EDIT: So there is this screen

image

Which I guess is referring to the commit and not when it was pushed? Either case im looking into it.

mdedetrich commented 9 months ago

So I just checked the logs and it did trigger https://github.com/lightbend-labs/jardiff/actions/runs/6962890536/job/18947517194 and publish, it should be available by now?

SethTisue commented 9 months ago

Huh, I don't remember that being there when I looked, maybe Actions was backed up or something 🤷

(btw the job shows up with the name "Clean", is that easily fixable?)

https://github.com/lightbend-labs/jardiff/releases/tag/v1.9.0

available: https://central.sonatype.com/artifact/com.lightbend/jardiff-core_2.13

https://github.com/retronym/homebrew-formulas/pull/5

SethTisue commented 9 months ago

@mdedetrich thanks for the help with this!

mdedetrich commented 9 months ago

(btw the job shows up with the name "Clean", is that easily fixable?)

There are 2 jobs, clean and continuous integration.

image

The actual publish is done in continuous integration and it only triggers if you happen to push a tag, which you can find here https://github.com/lightbend-labs/jardiff/actions/runs/6962890536

image

See how both the publish job is triggered and in the top left you see "Continuous Integration"

SethTisue commented 9 months ago

Got it 👍

mdedetrich commented 9 months ago

@SethTisue Did you end up making a homebrew release of the new version?

SethTisue commented 9 months ago

@mdedetrich I need Jason to merge https://github.com/retronym/homebrew-formulas/pull/5 . I'll ping him.

SethTisue commented 9 months ago

'tis merged