Closed SethTisue closed 9 months ago
@SethTisue Now that I think about it can you hold off the patch release until https://github.com/lightbend-labs/jardiff/issues/155 is done? I will try and do it tomorrow (shouldn't be too hard) but the reasoning is that currently its publishing cli related stuff along with Main
which doesn't make sense
sure, fine with me. see also #156
RELEASING.md
)@mdedetrich I added the secrets (using my personal Sonatype account, which has permissions for com.lightbend publishing)
after publishing, I'll need to revise https://github.com/retronym/homebrew-formulas/pull/5
@mdedetrich I can't remember where I left off on this. Like was I waiting for something else to happen? If you can't think of anything that's still pending, I guess I should try to push a tag? (There was #153, but since it hasn't progressed, maybe we should release anyway and figure on releasing again if a fix comes in.)
Yeah I was actually expecting a release at some point, the Windows fix can wait
(release steps from RELEASING.md)
sbt cli/assembly
jardiff.jar
shasum -a 256 jardiff.jar
to compute the SHA@mdedetrich no publish job was triggered. there must have been a flaw in https://github.com/lightbend-labs/jardiff/pull/152 ? is it obvious to you what went wrong here?
I'm not used to a setup with everything in ci.yml
— all the repos I work on have separate ci.yml
and release.yml
. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself
🎶 Please release me, let me go 🎶
@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here?
I'm not used to a setup with everything in
ci.yml
— all the repos I work on have separateci.yml
andrelease.yml
. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself
Did you push a tag? Pushing a tag with the vx.x.x
pattern is what forces a publish and judging from https://github.com/lightbend-labs/jardiff/tags the last tag was pushed 2 weeks ago?
EDIT: So there is this screen
Which I guess is referring to the commit and not when it was pushed? Either case im looking into it.
So I just checked the logs and it did trigger https://github.com/lightbend-labs/jardiff/actions/runs/6962890536/job/18947517194 and publish, it should be available by now?
Huh, I don't remember that being there when I looked, maybe Actions was backed up or something 🤷
(btw the job shows up with the name "Clean", is that easily fixable?)
https://github.com/lightbend-labs/jardiff/releases/tag/v1.9.0
available: https://central.sonatype.com/artifact/com.lightbend/jardiff-core_2.13
@mdedetrich thanks for the help with this!
(btw the job shows up with the name "Clean", is that easily fixable?)
There are 2 jobs, clean and continuous integration.
The actual publish is done in continuous integration and it only triggers if you happen to push a tag, which you can find here https://github.com/lightbend-labs/jardiff/actions/runs/6962890536
See how both the publish job is triggered and in the top left you see "Continuous Integration"
Got it 👍
@SethTisue Did you end up making a homebrew release of the new version?
@mdedetrich I need Jason to merge https://github.com/retronym/homebrew-formulas/pull/5 . I'll ping him.
'tis merged
now that #152 by @mdedetrich is merged, let's make sure we can use it
first, I'll need to add publishing secrets to the GitHub Actions config