search

lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
170 stars 23 forks source link

Publishing even when tag not pushed? #156

Closed SethTisue closed 9 months ago

SethTisue commented 10 months ago

@mdedetrich https://github.com/lightbend-labs/jardiff/actions/runs/6712606326/job/18242556792 failed with a failed attempt to publish. perhaps the attempt would have succeeded once I added secrets, but I think it shouldn't have even tried? I suggest we not publish after every merged PR, only when a tag was pushed.

mdedetrich commented 10 months ago

I suggest we not publish after every merged PR, only when a tag was pushed.

Actually this is the best way to test it (normally it's only meant to publish snapshots). I'll look at it tomorrow

SethTisue commented 10 months ago

okay, no opinion about how we handle it during testing, but I'd like to shut it off eventually

mdedetrich commented 9 months ago

@SethTisue Is this still an issue for you?

Personally I am a fan of having a snapshot published whenever a PR is merged into main because it lets users easily test the changes in their existing projects (the snapshot version also handily contains the git commit hash) and if there is a problem it can be fixed in a future PR.

Otherwise people have to go through the pain of having to publish locally/in their own nexus repo etc etc

wdyt? Otherwise I will remove the publishing of snapshots

SethTisue commented 9 months ago

Are the snapshots only published to Maven Snapshots and not to Maven Central? If so, I'm okay with it.

mdedetrich commented 9 months ago

Are the snapshots only published to Maven Snapshots and not to Maven Central?

It definitely publishes snapshot versions to maven snapshots, this is automatically handled by the plugin.

If so, I'm okay with it.

Cool ill close the issue then