search

lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
170 stars 23 forks source link

Add publish info #157

Closed mdedetrich closed 10 months ago

mdedetrich commented 10 months ago

Likely causing the issues with not publishing correctly.

SethTisue commented 10 months ago

I just noticed that the sbt-ci-release readme says:

Make sure build.sbt does not define any of the following settings

  • version: handled by sbt-dynver
  • publishTo: handled by sbt-ci-release
  • publishMavenStyle: handled by sbt-ci-release
  • credentials: handled by sbt-sonatype

@mdedetrich This PR seems to contradict that advice?

mdedetrich commented 10 months ago

@SethTisue That may be the issue, however I just realized that the issue with publishing is apparently due to wrong credentials (see https://github.com/sbt/sbt-pgp/issues/182)

SethTisue commented 10 months ago

I've submitted #162 which reverts these changes.

SethTisue commented 10 months ago

Likely causing the issues with not publishing correctly

At the time you submitted this PR, I hadn't added the secrets yet.