search

lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
170 stars 23 forks source link

remove unnecessary build stuff #162

Closed SethTisue closed 10 months ago

SethTisue commented 10 months ago

at least, I don't think any of this stuff is recommended or necessary under sbt-ci-release?

@mdedetrich the pomIncludeRepository, I'm least sure about it. do you know what that's for?

note that before this change (but after I added the secrets to the repo) we were seeing successful snapshot publishing at e.g. https://github.com/lightbend-labs/jardiff/actions/runs/6746086611/job/18339309410

so if we merge this, we should double check after that it's still working

mdedetrich commented 10 months ago

@mdedetrich the pomIncludeRepository, I'm least sure about it. do you know what that's for?

This is again one of those cargo culty things, I would say leave it in there unless the other plugins ( i.e. sbt-ci-release) explicitly set it since every single "scala thing that publishes to sonatype" has it in there