search

lightbend-labs / jardiff

A tool for comparing JAR files, including method bodies and Scala 2 pickled signatures
Apache License 2.0
172 stars 23 forks source link

Homebrew isn't recognizing the formula? #51

Closed SethTisue closed 3 years ago

SethTisue commented 3 years ago 
% brew install retronym/formulas/jardiff
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
Error: No available formula or cask with the name "retronym/formulas/jardiff".

not sure if somehow caused by https://github.com/retronym/homebrew-formulas/pull/1 , or what? @retronym

retronym commented 3 years ago

Weird. I reproduced that problem, then poked things a bit ("brew uninstall jardiff") and it seems to work again.

brew install retronym/formulas/jardiff
Updating Homebrew...
==> Installing jardiff from retronym/formulas
==> Downloading https://github.com/scala/jardiff/releases/download/v1.6.0/jardiff.jar
Already downloaded: /Users/jz/Library/Caches/Homebrew/downloads/8d21de597dd69
SethTisue commented 3 years ago

that didn't work for me

and then the next thing I tried was:

% brew untap retronym/formulas
Untapping retronym/formulas...
Untapped 2 formulae (43 files, 37.4KB).

followed by:

~ % brew install retronym/formulas/jardiff                                                                  [master|✚1]
==> Tapping retronym/formulas
Cloning into '/usr/local/Homebrew/Library/Taps/retronym/homebrew-formulas'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 28 (delta 1), reused 4 (delta 0), pack-reused 18
Receiving objects: 100% (28/28), 5.45 KiB | 2.73 MiB/s, done.
Resolving deltas: 100% (5/5), done.
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/retronym/homebrew-formulas/jardiff.rb
jardiff: /usr/local/Homebrew/Library/Taps/retronym/homebrew-formulas/jardiff.rb:9: `@1' is not allowed as an instance variable name
/usr/local/Homebrew/Library/Taps/retronym/homebrew-formulas/jardiff.rb:9: syntax error, unexpected end-of-input, expecting end
  depends_on openjdk@11
                    ^
Error: Cannot tap retronym/formulas: invalid syntax in tap!

and I get the same error if I simply brew install retronym/formulas/jardiff without the brew tap ... first

retronym commented 3 years ago

Try this one: https://github.com/retronym/homebrew-formulas/commit/57bddcc0430250b6555fa920ba56367e7cdd5d16

SethTisue commented 3 years ago

works!