search

lightbend-labs / mima

A tool for catching binary incompatibility in Scala
Apache License 2.0
459 stars 71 forks source link

Drop sbt 1.0.0 from test matrix #255

Closed dwijnand closed 5 years ago

dwijnand commented 5 years ago

The failure in PR #246 was because of a bug in sbt 1.0.0.

The reason sbt 1.0.0 is in the test matrix is to validate that sbt-mima works against sbt 1.0.0. The drawback of only testing against latest sbt is that sbt-mima would be able to depend on an API that was recently introduced in sbt and therefore it would only work with that later version of sbt.

However. Upgrading the sbt version in your build should be easy and safe. So there's no need to enforce that the plugin works on older sbt 1 versions.

Let's drop sbt 1.0.0.

SethTisue commented 5 years ago

we discussed this a while in person. there is some argument to be made that continuing to test 1.0.0 helps validate sbt's compatibility promises, but I figure doing that isn't really MiMa's job

(and in a MiMa context, we definitely don't care about sbt 1.0.x users anymore, people ought to be on 1.1.x minimum by now, preferably 1.2.x)