search

lightbend-labs / mima

A tool for catching binary incompatibility in Scala
Apache License 2.0
459 stars 71 forks source link

Review (self) usage of MiMa #280

Closed dwijnand closed 5 years ago

dwijnand commented 5 years ago

In some recent PRs I've been fixing up parts of the implementation. In doing so I've changed some class and method definitions and MiMa reports them as binary API breakage. But what is MiMa's public, binary API? Like is too common in Scala everything is public, so we'll have to try and reverse engineer what can retroactively be called public vs private API. At the very minimum the sbt keys, their types and related utility classes (i.e ProblemFilters).

SethTisue commented 5 years ago

it seems reasonable to me to simply be very liberal about bumping the version number