search

lightbend-labs / mima

A tool for catching binary incompatibility in Scala
Apache License 2.0
459 stars 71 forks source link

add explicit type #784

Closed xuwei-k closed 1 year ago

xuwei-k commented 1 year ago

prepare Scala 2.13.12

[error] core/src/main/scala/com/typesafe/tools/mima/core/PackageInfo.scala:14:7: under -Xsource:3, inferred com.typesafe.tools.mima.core.PackageInfo instead of com.typesafe.tools.mima.core.NoPackageInfo.type [quickfixable]
[error] Scala 3 migration messages are errors under -Xsource:3. Use -Wconf / @nowarn to filter them or add -Xmigration to demote them to warnings.
[error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=scala3-migration, site=com.typesafe.tools.mima.core.NoPackageInfo.owner
[error]   val owner       = this
[error]       ^
[error] core/src/main/scala/com/typesafe/tools/mima/core/PackageInfo.scala:15:7: under -Xsource:3, inferred com.typesafe.tools.mima.core.Definitions instead of Nothing [quickfixable]
[error] Scala 3 migration messages are errors under -Xsource:3. Use -Wconf / @nowarn to filter them or add -Xmigration to demote them to warnings.
[error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=scala3-migration, site=com.typesafe.tools.mima.core.NoPackageInfo.definitions
[error]   def definitions = sys.error("Called definitions on NoPackageInfo")
[error]       ^
lightbend-cla-validator commented 1 year ago

Hi @xuwei-k,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla