search

lightbend-labs / scala-rewrites

Scalafix Rewrites for Scala
Apache License 2.0
46 stars 21 forks source link

Latest release (0.1.3) doesn't work with Scala 2.13.9+ #182

Closed Jaystified closed 1 year ago

Jaystified commented 1 year ago

0.1.3 has been released over two years ago and doesn't work with latest Scala 2 versions.

Although this repo keeps getting updates and the problem has been solved in the main branch for a while, compiling it locally as a dependency is inconvenient and a new release is preferable.

Is there a chance for a new release in the near future?

SethTisue commented 1 year ago

Sadly, this repo is currently without anyone really overseeing it and driving it forward. So for example, it would be nice if a volunteer could try and figure out how to get https://github.com/scala/scala-rewrites/pull/181 through. (I fear that the problem you're hitting won't be fixed even in 0.1.4, and #181 is needed in order for it to work? Not sure.)

But regardless, we should roll a release with whatever we currently have, as a new baseline. I've pushed a tag: https://github.com/scala/scala-rewrites/releases/tag/v0.1.4

But the release build failed:

[info] gpg: no default secret key: No secret key
[info] gpg: signing failed: No secret key

I'll look into that next.

SethTisue commented 1 year ago

I've transferred the repo to the lightbend-labs org, to better reflect the maintenance status.

SethTisue commented 1 year ago

okay, https://github.com/lightbend-labs/scala-rewrites/releases/tag/v0.1.4 worked once I added the needed secrets to the repository, as per the sbt-ci-release documentation

@Jaystified could you (or could anyone watching this repo) give the release a try and see if it resolves the issue...?

(after artifacts arrive on Maven Central, which might take 15 minutes or so...)

Jaystified commented 1 year ago

Thanks @SethTisue ! I've given v0.1.4 a go and it seems to work. I was able to compile & test with Scala 2.13.11 / scalafix 0.11.0 . It sure does spit out a lot of warnings, though. (probably due to #181 as you've mentioned the Scala version upgrade from 2.13.8)

Jaystified commented 1 year ago

(Memo for anyone else looking up this problem) I should probably clarify that my projects using Scala 2.13.11 and having scalafix 0.11.0 / scala-rewrites v0.1.4 as dependencies compile without complaining about other dependencies. Running scalafix doesn't work.

However, with Scala 2.13.10 and scalafix 0.10.4 / scala-rewrites 0.1.4 the scalafix command does work, so as-written this issue is (correctly) closed.

SethTisue commented 1 year ago

How about 0.1.5? (It's on its way to Maven Central, should be there in 15 minutes or so.)

Jaystified commented 1 year ago

Yes, thanks! Scala 2.13.11 + scalafix 0.11.0 + scala-rewrites v0.1.5 does allow running scalafix without any errors that I can see.